Move JoinColumn nullability check to drivers
#8726
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Annotation and Attribute drivers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft solution for #8723. This PR moves
nullablelogic onJoinColumnfromClassMetadataInfoto drivers and implements reflection fallback for Annotation and Attribute drivers.Logic here is to use property nullability if and only if there are
JoinColumnannotation/attributes that doesn't havenullableset, thus limiting possible BC to situation whenJoinColumnis set withoutnullableand the property is not nullable.This logic can be extended to other drivers if desired. Also I didn't add any tests (yet!) to get the approach reviewed first.