-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge release 2.9.3 into 2.10.x #8765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark 2.8.x as unmaintained, and 2.9.x as current
Fix ClassMetadaInfo template inference
Handle generic parameters in UnitOfWork
Co-authored-by: Claudio Zizza <[email protected]>
* Add automatic type detection for Embedded. * Inline statement. Co-authored-by: Benjamin Eberlei <[email protected]>
Make ClassMetadata covariant
Fix metadata constructor inference by phpstan
Add ReturnTypeWillChange to ReflectionEmbeddedProperty
Use correct named argument syntax in docs
There used to be no constructor in this class, adding one with mandatory arguments was technically a BC-break. Fixes #8753
Restore bc for annotations
* fix: handle repeatable attributes * Restore interface compatibility A reader is supposed to only ever return objects. By introducing RepeatableAttributeCollection, we fulfill the interface and improve clarity. * refactor: accurate type declarations and returns * refactor: remove unused use * Ignore AttributeReader in phpstan and psalm to pass on CI running PHP 7.4. * test: isTransient Co-authored-by: Grégoire Paris <[email protected]> Co-authored-by: Benjamin Eberlei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes for 2.9.3
2.9.x bugfix release (patch)
2.9.3
Total issues resolved: 2
Total pull requests resolved: 5
Total contributors: 5
8758: Restore bc for annotations thanks to @greg0ire
8756: fix: handle repeatable attributes thanks to @ph-fritsche
8753: Edge-case regression with 2.9.x thanks to @albe
8742: Add ReturnTypeWillChange to ReflectionEmbeddedProperty thanks to @derrabus
8734: Fix metadata constructor inference by phpstan thanks to @VincentLanglet
Bug