Rename Abstract*Test to *TestCase #9806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jun 2, 2022
derrabus
added a commit
to derrabus/orm
that referenced
this pull request
Jun 3, 2022
* 2.13.x: PHPStan 1.7.9 (doctrine#9812) Remove empty test file (doctrine#9805) Remove calls to deprecated MockBuilder::setMethods() (doctrine#9808) Deprecate passing null to Query::setFirstResult() Rename Abstract*Test to *TestCase (doctrine#9806) Add primary key on temp table (doctrine#9770) Fix wrong types (doctrine#9802) Widen return type Update baseline Fix Add type for AssociationMapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 10 will complain about abstract classes suffixed with
Test. This is why I've renamed all of those classes to use the suffixTestCaseinstead. Since we use that suffix already for some of the abstract test case classes, our class naming should become a little more consistent this way.