Emit deprecation for LifecycleEventArgs::getEntity #281
Conversation
| @@ -41,6 +42,13 @@ public function __construct($object, ObjectManager $objectManager) | |||
| */ | |||
| public function getEntity() | |||
| { | |||
| Deprecation::trigger( | |||
| 'doctrine/persistence', | |||
| 'https://github.com/doctrine/persistence/pull/281', | |||
There was a problem hiding this comment.
Let's refer to the original PR or issue instead? It was before PRs were used, but we still could use the link to the commit I suppose: aca6f03 It does not explain much, so I let you judge what is best.
There was a problem hiding this comment.
I wanted to, but simple annotation led me to code migration 🙈 I'll dig further
There was a problem hiding this comment.
yeaaah, deprecated for 10 years now! aca6f03
malarzm
force-pushed
the
malarzm-patch-2
branch
from
9af15eb to
bf3cb9e
Compare
malarzm
force-pushed
the
malarzm-patch-2
branch
from
bf3cb9e to
ad2a9ff
Compare
The method itself had `@deprecated` on it for a long time
malarzm
force-pushed
the
malarzm-patch-2
branch
from
ad2a9ff to
7fe015c
Compare
|
Thanks @malarzm ! |
|
This really didn't need runtime behaviour additions: it was fully statically verifiable. |
|
It'd be weird that we emit deprecations for everything but this one tho :) |
|
Yikes, it's gone awfully sideways then 😱 |
|
@Ocramius what's so wrong about having the deprecation reported through both mechanisms? https://www.doctrine-project.org/policies/deprecation.html clearly needs a refresh, so now would be a good time to have a discussion about this. |
The method itself had
@deprecatedon it for a long time