Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--github @typedef links don't make sense #1027

Closed
jaydenseric opened this issue Mar 1, 2018 · 1 comment
Closed

--github @typedef links don't make sense #1027

jaydenseric opened this issue Mar 1, 2018 · 1 comment

Comments

@jaydenseric
Copy link
Contributor

jaydenseric commented Mar 1, 2018

Using --github, the generated links for @typedef target unexpected lines in source code. They seem to target entities they are used in, rather than where the type was defined.

Try for example the ActiveQuery source link: https://github.com/jaydenseric/graphql-react/blob/99142e9974499e54513026ec933d1e5d3e82eeac/readme.md#activequery

You would expect it to target here instead.

  • What version of documentation.js are you using?: v5.4.0
  • How are you running documentation.js (on the CLI, Node.js API, Grunt, other?): CLI
jaydenseric added a commit to jaydenseric/graphql-react that referenced this issue Mar 1, 2018
@tmcw
Copy link
Member

tmcw commented Mar 2, 2018

Thanks to Bob Lannon, this is now fixed in 5.5.0 and 6.0.0! #1024

@tmcw tmcw closed this as completed Mar 2, 2018
RyanWooldridge added a commit to RyanWooldridge/React-graphql that referenced this issue Aug 21, 2019
denisp22 pushed a commit to denisp22/graphql-react that referenced this issue Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants