Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when run from CI #668

Closed
ghost opened this issue Feb 1, 2017 · 6 comments
Closed

Error when run from CI #668

ghost opened this issue Feb 1, 2017 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 1, 2017

Specifically, CircleCI:

yarn run test

yarn run v0.18.1
$ yarn run build-docs && nyc --reporter=html better-npm-run test 
yarn run v0.18.1
$ documentation build src/** --output docs/code/ --format html 
string_decoder.js:94
    buf.copy(this.lastChar, this.lastTotal - this.lastNeed, 0, this.lastNeed);
        ^

RangeError: out of range index
    at RangeError (native)
    at StringDecoder.fillLast (string_decoder.js:94:9)
    at StringDecoder.write (string_decoder.js:73:14)
    at readableAddChunk (_stream_readable.js:160:31)
    at ReadStream.Readable.push (_stream_readable.js:130:10)
    at onread (fs.js:1774:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:675:17)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yarn run test returned exit code 1

The same setup works when run locally.

@tmcw
Copy link
Member

tmcw commented Feb 4, 2017

Thanks for the report! I'm not 100% sure what's going on here yet, but could you let me know which node version you're using? CircleCI's default, v0.10, is very old and is likely to cause problems with this and other libraries - eslint, for instance, doesn't even run with the CircleCI default. If it's the default, maybe trying upgrading to v4?

@ghost
Copy link
Author

ghost commented Feb 4, 2017

Whoops, I should have mentioned that we're enforcing node v6 on Circle.

@ghost
Copy link
Author

ghost commented Mar 1, 2017

@tmcw Any thoughts on this? I gave it a shot again but ran into the same issue.

@tmcw tmcw added this to the beta20 milestone Apr 12, 2017
@tmcw
Copy link
Member

tmcw commented Apr 12, 2017

@bright-star it looks like you're running into this Node core bug that was introduced in 6.2.1 and fixed in 6.3.0. Try upgrading the version of Node on CircleCI to something 6.3.0 or newer?
nodejs/node#7308

@tmcw tmcw removed this from the beta20 milestone Apr 12, 2017
tmcw added a commit that referenced this issue Apr 12, 2017
This guards against potential core errors like the one possibly found in #668 and makes sure
documentation.js continues to be UTF8 friendly
@ghost
Copy link
Author

ghost commented Apr 12, 2017

Thanks for the update. We'll try that this week.

@ghost
Copy link
Author

ghost commented Apr 17, 2017

That worked out great, thanks!

@ghost ghost closed this as completed Apr 17, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant