WIP upgrade to babel 7 scoped packages

[maciej-ka]

#1029, #996

Keeping this MR open as WIP until problems are gone. And the problems are:

• Babelify package is not official repo but ylemkimon/babelify, because it would otherwise expect babel 6 and not work in this setup. (suggested by @vihanb)
• Some tests are failing. This MR has already a few adjustments to address breaking changes. I think Babelify produces a bit different AST which is a source of few snapshot reds. And some complaints about forEach on undefined are a total mystery for me at this point.

[maciej-ka]

Fragment here is added to test #1029

[maciej-ka]

jest@test which uses Babel 7 seems to still require unscoped babel-core import. I couldn't start the tests without it. Read more here

[tmcw]

Cool! Sorry, been busy with the day job but taking a look now...

Not sure if you've used https://astexplorer.net but it's a godsend for this kind of development. Toggling between babylon6 and babylon7 helps a bit showing the AST changes. Also there's a post about some renamings - tried out one of them, and it already cuts down on failed tests to replace all references to NumericLiteralTypeAnnotation with NumberLiteralTypeAnnotation.

[maciej-ka]

Thanks for links, I was looking for exactly something like them.

I have a bit unexpected situation, for around two weeks I don't have a quiet place to work and I have to halt my open source activity (trying to do it next to crying babies frustrated me a lot). See you soon after I'm over these problems.

[cyrilchapon]

Any update on this ?
Any temporary workaround to make this work with babel7 ?

[jaydenseric]

I suspect updating Babel might fix #1092.

[jaydenseric]

@cyrilchapon I haven't noticed any issues with Babel v7 until now, but then again I use babel.config.js (a Babel v7 convention) and it seems documentation.js only notices and freaks out with .babelrc: #996.

[cyrilchapon]

@jaydenseric, thanks for this.

I haven't noticed any issues with Babel v7 until now

Are you using @latest from documentation.js npm ?

I'll give a try to babel.config.js, I'm indeed using .babelrc

[jaydenseric]

The official babelify project supports Babel v7 now: https://github.com/babel/babelify/blob/v9.0.0/package.json#L16

[iztsv]

@maciej-ka thanks for the working on the feature!

Can you explain when that will be available?

[tmcw]

My preference is to wait until Babel 7 is released - it's currently still a beta release, and there are still stable releases of Babel 6. The 7 release has been pushed back several times - it was 'soon' in Sept 2017. If we were to jump the gun on this, then documentation.js would stop working with, most likely, the majority of projects that use it with Babel 6, and we'd have to backport changes until Babel 7 is the stable and recommended version.

[smokku]

Babel 7 was just released.

[puttpotsawee]

Any update on this? Babel 7 was officially released!

[tmcw]

I think #1114 is a roughly more-complete branch that also approaches the Babel 7 upgrade.

[puttpotsawee]

@tmcw It's working now!
In package.json, I change

"documentation": "^8.1.2"

to

"documentation": "git+ssh://github.com/vicapow/documentation#update-babel-dist"

and it works like charm

[tmcw]

Thanks for the hard work, and sorry for the communication failure - the update-babel PR is now merged, and the first Babel 7 prelease, 9.0.0-alpha.0 is pushed.