Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(params): Parameters with default use = not ? #757

Merged
merged 1 commit into from
Apr 26, 2017
Merged

fix(params): Parameters with default use = not ? #757

merged 1 commit into from
Apr 26, 2017

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Apr 25, 2017 •
edited
Loading

  • Corrects infer/params to avoid marking parameters with default as optional
  • Uses lib/parse to 'massage' doctrine's optional parameters into normal parameters with default values.

Do you think this is the correct approach, or should it be handled on the output side?

Fixes #737

@tmcw tmcw requested a review from arv April 25, 2017 01:23
arv
arv approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@arv arv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If the theme wants to document these in a way that signifies that the caller can pass in undefined then they can still do that.

@tmcw tmcw merged commit 3cc4426 into master Apr 26, 2017
@tmcw tmcw deleted the optional-not-nullable branch April 26, 2017 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arv arv arv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmcw @arv