Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging configs should be by prioritize. #864

Merged
merged 1 commit into from
Aug 4, 2017

Conversation

anthony-redFox
Copy link
Member

The first priority from CLI(from user) settings then package.json.

Fixed #845

The first priority from CLI(from user) settings then package.json.

Fixed documentationjs#845
@tmcw tmcw self-requested a review August 4, 2017 16:17
Copy link
Member

@tmcw tmcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and yeah, better to go with some simple vanilla JS than contort to use all that lodash here :)

@tmcw tmcw merged commit ecf16bd into documentationjs:master Aug 4, 2017
@anthony-redFox anthony-redFox deleted the overrideProjectName branch August 7, 2017 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants