Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

Docz external resolve fix #821

Closed
wants to merge 3 commits into from
Closed

Conversation

ejuo
Copy link
Contributor

@ejuo ejuo commented Apr 20, 2019

Fix for #783

@patricksevat
Copy link
Contributor

I think it's a nicer solution. But when trying to run examples I run into some an error:

These relative modules were not found:

* ./components/ui in C:/rfs/docz/core/docz-theme-default/dist/index.esm.js
* ./config in C:/rfs/docz/core/docz-theme-default/dist/index.esm.js
* ./styles/global in C:/rfs/docz/core/docz-theme-default/dist/index.esm.js
* ./styles/modes in C:/rfs/docz/core/docz-theme-default/dist/index.esm.js
* ./utils/theme in C:/rfs/docz/core/docz-theme-default/dist/index.esm.js

When removing the external prop in docz-theme-default/rollup.config.js it builds and runs correctly.

@ejuo
Copy link
Contributor Author

ejuo commented Apr 24, 2019

@patricksevat,
Fix it, thanks.

@pedronauck
Copy link
Member

You need to upgrade your branch dude, your commit changes with a lot of changelog stuff.

@ejuo
Copy link
Contributor Author

ejuo commented Apr 24, 2019

You need to upgrade your branch dude, your commit changes with a lot of changelog stuff.

@pedronauck , is it normal that the dev branch has version 1.0.3, unlike master 1.0.4?

@pedronauck
Copy link
Member

It's not normal, thanks to the warning, it's both updated now 🙏

@ejuo
Copy link
Contributor Author

ejuo commented Apr 24, 2019

@pedronauck , what else is required?

@pedronauck
Copy link
Member

You need to update your branch, as you can see, as sow many files changed inside your pull request. Try to keep just the change that you made.

@ejuo ejuo closed this Apr 24, 2019
@ejuo
Copy link
Contributor Author

ejuo commented Apr 24, 2019

@pedronauck, I recreated the PR, so that only current changes are visible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants