Skip to content
This repository has been archived by the owner on Jan 24, 2025. It is now read-only.

feat: resolve markdown images #851

Merged
merged 1 commit into from
May 8, 2019
Merged

feat: resolve markdown images #851

merged 1 commit into from
May 8, 2019

Conversation

remcohaszing
Copy link
Contributor

Description

Markdown images are converted to MDX and require statements. This way referencing local images using markdown syntax is now supported.

Review

  • Check the copy
  • ...
  • ...

Pre-merge checklist

  • ...
  • ...

Screenshots

Before After
image image

Markdown images are converted to MDX and require statements. This way
referencing local images using markdown syntax is now supported.
@remcohaszing
Copy link
Contributor Author

This was a quick and hasty implementation. Most notably this doesn’t work for <img /> tags in Markdown. Please let me know if you’re interested in me finalizing this feature.

If not, I’ll release this as a separate remark plugin.

@pedronauck pedronauck merged commit 0fb41c8 into doczjs:dev May 8, 2019
pedronauck pushed a commit that referenced this pull request May 8, 2019
Markdown images are converted to MDX and require statements. This way
referencing local images using markdown syntax is now supported.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants