Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Should_break_after_4_concurrent_calls looks flaky #52

Closed
Ceridan opened this issue Nov 8, 2020 · 1 comment
Closed

Test Should_break_after_4_concurrent_calls looks flaky #52

Ceridan opened this issue Nov 8, 2020 · 1 comment
Labels
tests Testing
Milestone
v2.0.0

Comments

@Ceridan
Copy link
Contributor

Ceridan commented Nov 8, 2020

Test Should_break_after_4_concurrent_calls looks flaky. It usually represents on my local machine. 2 of 3 tests are failed for netcoreapp2.1:

Dodo.HttpClientResiliencePolicies.Tests.CircuitBreakerTests.Should_break_after_4_concurrent_calls

  Expected: 2
  But was:  3
@Ceridan Ceridan added the tests Testing label Nov 8, 2020
Ceridan added a commit that referenced this issue Nov 19, 2020
@Ceridan
test: Change flaky test, pretend to be more stable (#52)
8f27234
@Ceridan Ceridan added this to the v2.0.0 milestone Nov 19, 2020
Ceridan added a commit that referenced this issue Nov 19, 2020
@Ceridan
test: Fix flaky Should_break_after_4_concurrent_calls test (#52)
cd3cf7e
@Ceridan Ceridan mentioned this issue Nov 20, 2020
Merged
@Ceridan
Copy link
Contributor Author

Ceridan commented Nov 21, 2020

Closed by #57

@Ceridan Ceridan closed this as completed Nov 21, 2020
@Ceridan Ceridan mentioned this issue Dec 5, 2020
Merged
Ceridan added a commit that referenced this issue Dec 5, 2020
@Ceridan
Merge pull request #60 from dodopizza/milestone/v2.0.0
810c8d1 
Milestone v2.0.0

Milestone include major changes including breaking changes.
Full list of changes:
- Fix namespace clash between Dodo.HttpClient and System.Net.Http.HttpClient (#32)
- Add OverallTimeoutPolicy (#13)
- AddDefaultPolicies is renamed to AddResiliencePolicies (#45)
- CircuitBreaker is host specific by default. Host agnostic version is removed (#44)
- HttpClientSettings is replaced with ResiliencePoliciesSettings (#38)
- Add support of Retry-After http header (#40)
- Refactor API for end-users (#51)
- Re-write README (#24)
- Add .NET 5 support (#53)
- Fix flaky test (#52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Testing
Projects
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@Ceridan