Refactor and enhance Dialog handling in OSLib for improved safety and eficiency #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored ConfigureDialog function for better reuse across different dialog types. - Added error handling for all sceUtility* function calls. - Replaced strcpy with strncpy to prevent potential buffer overflows. - Enhanced oslDrawDialog to handle multiple dialog types more efficiently. - Simplified dialog state management. - Consolidated code and improved formatting for readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR improves the dialog handling logic in OSLib by refactoring and optimizing various functions for better readability, maintainability, and safety. Key changes include:
sceUtility*functions are checked and handled appropriately. This avoids ignoring potential errors during dialog initialization and updates.strcpywithstrncpyto safely copy message strings and prevent buffer overflows.oslDrawDialog: Improved logic for drawing dialogs, managing their states, and handling multiple dialog types (message, error, network, OSK, save/load, and browser dialogs).dialogTypeand status checks) and streamlined the process of detecting active dialogs.These improvements increase the overall robustness of the library and ensure that dialogs are handled safely and efficiently.