Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

add jwt support, support timeseries, fix error handling and fix dependencies #322

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

visualcortex-team
Copy link
Contributor

What this PR does / why we need it:

The current implementation of this plugin has a few issues relating to Alerts:

  • The Google JWT File Authentication Type is not implemented.
  • The alert response does not support the Format as Timeseries (only Table works).
  • Project ID is not correctly used by the plugin.
  • Grafana parameters (like ${__from:date:seconds}) are not correctly substituted.
  • Dependencies were largely out of date.

Which issue(s) this PR fixes:

This PR aims to fix the above issues.

Fixes #

Special notes for your reviewer:

Release note:

Fixes `Alert` functionality:
- The `Google JWT File` Authentication Type is now supported.
- The alert response supports the `Format as` `Timeseries`.
- Project ID/Default Project ID is now correctly used by the plugin.
- Grafana parameters (like `${__from:date:seconds}`) are substituted.

@ofir5300
Copy link
Collaborator

Great contribution @visualcortex-team !

Fixes #301
Fixes #303
Fixes #305

@ofir5300 ofir5300 changed the base branch from master to OfirCohen/v2.0.2 April 22, 2021 07:20
@ofir5300 ofir5300 merged commit 6973a08 into doitintl:OfirCohen/v2.0.2 Apr 22, 2021
@ofir5300 ofir5300 mentioned this pull request May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants