[d3d11] Add stub IDXGIKeyedMutex interface. #3601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially based on a patch by Derek Lesho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially based on a patch by Derek Lesho.
I am planning on implementing the real support for that (in Proton's winevulkan first), although I guess it should be nothing wrong in having a stub meanwhile. Worst case I think some games will have videos starting showing up but still flickering. The stub already helps some games to properly show videos.
I tested that if the shared resource is created without D3D11_RESOURCE_MISC_SHARED_KEYEDMUTEX, QueryInterface indeed returns E_NOINTERFACE on Windows. It also seems to me that keyed mutex implementation belongs to DXGI resource (like other shared resources stuff) rather than to D3D11 textures of specific types.