D3D11: Support debug names for resources #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitsujin
force-pushed
the
debug-utils-stuff-v2
branch
from
dbbffad to
27bc146
Compare
doitsujin
force-pushed
the
debug-utils-stuff-v2
branch
from
27bc146 to
025c4ba
Compare
doitsujin
force-pushed
the
debug-utils-stuff-v2
branch
from
025c4ba to
3d8757c
Compare
Makes it easier to work out what is allocated where.
Co-authored-by: Aaron Leiby <[email protected]>
Ensures that we correctly begin and end app-provided regions within each command buffer.
doitsujin
force-pushed
the
debug-utils-stuff-v2
branch
from
3d8757c to
5a6552c
Compare
doitsujin
force-pushed
the
debug-utils-stuff-v2
branch
from
5a6552c to
74307e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4589. Requires setting
DXVK_DEBUG=markersto do anything.I've tested this with some Unity Engine stuff, generally appears to work.
We can't meaningfully support resource views and samplers since the backend deduplicates them. Shaders would be nice to have support for, but those are very tricky too since we don't know the debug name at compile time.
In case of buffers, enabling debug names does alter overall DXVK behaviour in that we now have to create dedicated
VkBuffers for each D3D11 buffer. We ignore small buffers that are serviced by the allocation cache here since otherwise we'd end up creating and destroying thousands ofVkBufferobjects per frame.There's a couple other things I'd like to do, mostly annotating our various different command buffers since it can be a bit difficult to figure out what's going on in a capture these days. Edit: Done.
CC @aleiby