Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.dojorc extends support with @speedy/json-extends #297

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

JamesLMilner
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

Description:

The aim is to add a extends property to .dojorc which will allow for extension for a .dojorc from another previously defined .dojorc configuration.

This PR aims to:

  • Allow for multiple nested extension, i.e. a .dojorc file can extend another .dojorc file which can extend another and so forth indefinitely.
  • Provide deep 'merging' of configuration objects (i.e. configuration property values that are also objects will be recursively merged). This will only work for Objects and not Arrays or other types (we have agree this isn't such a great idea as per Feature request: allow user to merge extended arrays in tsconfig files microsoft/TypeScript#20110).

Resolves #295

Sorry, something went wrong.

package.json Outdated
@@ -48,6 +48,7 @@
"typings.json"
],
"dependencies": {
"@speedy/json-extends": "^1.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we pin the dep please?

@JamesLMilner JamesLMilner changed the title Handle extensions speedy .dojorc extends support with @speedy/json-extends Sep 24, 2019
@JamesLMilner JamesLMilner force-pushed the handle-extensions-speedy branch from 714b2d9 to 3372e52 Compare September 24, 2019 13:13
@@ -72,7 +73,7 @@ export async function loadCommands(paths: string[], load: (path: string) => Comm
}
}
} catch (error) {
error.message = `Failed to load module ${path}\nNested error: ${error.message}`;
error.message = `${chalk.red(`Failed to load module ${path}`)}\n\nNested error:\n ${error.message}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related?

@JamesLMilner JamesLMilner merged commit fc762b3 into dojo:master Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support extending dojorc configuration
2 participants