spawn the server in torii

dojoengine · Oct 19, 2024 · 06df0d0 · 06df0d0
1 parent fd3b89d
commit 06df0d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bin/torii/src/main.rs b/bin/torii/src/main.rs
@@ -298,10 +298,8 @@ async fn main() -> anyhow::Result<()> {
     if let Some(listen_addr) = args.metrics {
         info!(target: LOG_TARGET, addr = %listen_addr, "Starting metrics endpoint.");
         let prometheus_handle = PrometheusRecorder::install("torii")?;
-        dojo_metrics::Server::new(prometheus_handle)
-            .with_process_metrics()
-            .start(listen_addr)
-            .await?;
+        let server = dojo_metrics::Server::new(prometheus_handle).with_process_metrics();
+        tokio::spawn(server.start(listen_addr));
     }
 
     let engine_handle = tokio::spawn(async move { engine.start().await });

diff --git a/crates/metrics/src/server.rs b/crates/metrics/src/server.rs
@@ -21,6 +21,8 @@ type BoxedHook = Box<dyn Hook<Output = ()>>;
 type Hooks = Vec<BoxedHook>;
 
 /// Server for serving metrics.
+// TODO: allow configuring the server executor to allow cancelling on invidiual connection tasks.
+// See, [hyper::server::server::Builder::executor]
 pub struct Server<MetricsExporter> {
     /// Hooks or callable functions for collecting metrics in the cases where
     /// the metrics are not being collected in the main program flow.