-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(walnut): put under walnut
feature flag
#2407
Conversation
WalkthroughOhayo, sensei! This pull request updates the Changes
Possibly related PRs
Tip Announcements
Recent review detailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2407 +/- ##
=======================================
Coverage 68.13% 68.14%
=======================================
Files 364 364
Lines 47712 47746 +34
=======================================
+ Hits 32509 32535 +26
- Misses 15203 15211 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for gating that under a feature.
@@ -198,7 +201,7 @@ pub async fn revoke_writer<A>( | |||
new_writers: &[ResourceWriter], | |||
txn_config: &TxnConfig, | |||
default_namespace: &str, | |||
walnut_debugger: &Option<WalnutDebugger>, | |||
#[cfg(feature = "walnut")] walnut_debugger: &Option<WalnutDebugger>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird why fmt is using only one line in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah im not sure, i dont like the look of it as well but oh well
put all walnut code in Sozo under the
walnut
feature flag which will be enabled by default.Summary by CodeRabbit
New Features
sozo-walnut
dependency.WalnutDebugger
, enabling modular debugging options based on feature activation.Bug Fixes
WalnutDebugger
.Documentation
Tests