Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sozo manifest when possible to avoid recomputing diff #2649

Merged
merged 4 commits into from
Nov 7, 2024

tests: add missing tests

19ab415
Select commit
Loading
Failed to load commit list.
Merged

fix: use sozo manifest when possible to avoid recomputing diff #2649

tests: add missing tests
19ab415
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 7, 2024 in 1s

57.40% (+0.06%) compared to a4adeb3

View this Pull Request on Codecov

57.40% (+0.06%) compared to a4adeb3

Details

Codecov Report

Attention: Patch coverage is 67.07819% with 80 lines in your changes missing coverage. Please review.

Project coverage is 57.40%. Comparing base (a4adeb3) to head (19ab415).

Files with missing lines Patch % Lines
bin/sozo/src/commands/execute.rs 0.00% 32 Missing ⚠️
crates/dojo/world/src/contracts/contract_info.rs 86.36% 21 Missing ⚠️
bin/sozo/src/commands/call.rs 0.00% 14 Missing ⚠️
bin/sozo/src/commands/options/account/mod.rs 0.00% 5 Missing ⚠️
crates/dojo/world/src/diff/manifest.rs 66.66% 3 Missing ⚠️
bin/sozo/src/utils.rs 0.00% 2 Missing ⚠️
bin/sozo/src/commands/events.rs 0.00% 1 Missing ⚠️
...in/sozo/src/commands/options/account/controller.rs 92.30% 1 Missing ⚠️
crates/sozo/scarbext/src/workspace.rs 92.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
+ Coverage   57.34%   57.40%   +0.06%     
==========================================
  Files         399      400       +1     
  Lines       49747    49903     +156     
==========================================
+ Hits        28527    28647     +120     
- Misses      21220    21256      +36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov