-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeated erroneous notifications when Github can't be reached #86
Comments
The tool should already check the Github status api... but maybe there is a delay before downtime is mentioned there? (or that status lookup in the tool is failing?) status check code: https://github.com/dokufreaks/dokuwiki-translation/blob/master/src/org/dokuwiki/translatorBundle/Services/GitHub/GitHubStatusService.php |
Some delay for repeating the same message could nice for authors, but I think it requires storing last send message? Is there not a simpler trick possible? Is there maybe some heuristic for determining that all plugins have failing import? |
Older issue which notice the large bunch of messages due to github status: #56 |
I was flooded with messages, I guess some other people will have got a lot more.. |
Note: the flood of messages was because of https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/ I reset the SSH hostkey info and reset the error counts for all repos. |
Another attempt to damp the large amount of emails. I let retry the Tool, but stop sending emails if more than 5 errors occur in 8 min, after that it will start sending again if no errors occur in 8 min. (default, the tool does every 5 min a run and max 10 repositories per run) |
Yesterday, I've received repeated mails from the Dokuwiki translate tool. Apparently Github couldn't be reached for a couple of minutes from the translate server.
Occasionally (about once a month) I get single instances of this mail too.
I would propose to make the translate tool wait for a short while before sending out erroneous notifications and wait for a couple of hours before sending out the next notification.
Additionally the translate tool could check the Github Status API for downtime before reporting errors. (I could not immediately figure out if the app is doing this already.)
The text was updated successfully, but these errors were encountered: