-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with minizip-ng>=4.0.8 #13273
Conversation
Can you update |
I'm not sure why the Windows build is still failing, I'm in the process of creating a virtual machine so I can debug that locally. |
2024ef0
to
c8ca904
Compare
AFAICT, when using the system minizip-ng library, upstream does not provide the header files in the compat subdirectory, but directly in the root (not very familiar with C/C++, so my nomenclature might be a bit off), at least on my machine. Removing the |
8ffed89
to
7c36a4e
Compare
@dpeukert Could you please test if compiling with your system minizip-ng properly works now? I have tested locally but I'm not sure if I've done so correctly. |
@JoshuaVandaele Can confirm that I'm now able to build this PR. |
7c36a4e
to
fdf5038
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes compilation on Arch Linux.
fdf5038
to
75285e9
Compare
75285e9
to
fa442dc
Compare
FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:
automated-fifoci-reporter |
Knowing minizip this will inevitably break some other system, but I guess we'll take it anyway for the version update. |
Minizip-ng 4.0.8 introduced a change where the compatibility layer was split into multiple source files. This caused dolphin to fail to build. This PR aims to remedy that.
I tested compilation and launching a game that uses a resource pack, which both worked fine for me.