AboutDialog: Disable resizing the About window #13303
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
approved these changes
Jan 24, 2025
|
Does it play nice with HiDPI, per-monitor DPI and scaling? Probably does (or it was broken already before), but I ran into an application at work the other day that had a fixed-size window that was simply cut off when scaling was higher than 100% (but just that one, the rest was fine) |
|
I don't have the hardware to test that, but it simply disallows resizing once Qt is done calculating the required size for the window by itself, it should be fine |
BhaaLseN
approved these changes
Jan 24, 2025
mbc07
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the About Dialog window from being resized, which lead to this result:
It now cannot be maximized or otherwise resized: