Common: Make SmallVector work with non-standard-layout types. #13310
+78
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
Jan 26, 2025
jordan-woyak
force-pushed
the
small-vec-placement-new
branch
4 times, most recently
from
96cffa6 to
2712f23
Compare
|
This looks pretty good to me, but can you add some |
jordan-woyak
force-pushed
the
small-vec-placement-new
branch
from
2712f23 to
41365ab
Compare
JosJuice
approved these changes
Jan 26, 2025
jordan-woyak
force-pushed
the
small-vec-placement-new
branch
from
41365ab to
9777e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements are now constructed with placement-new.