ShaderGen: Fix broken rendering on Adreno Vulkan drivers #7729
+169
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the clipPos varying unless slow-depth is used, and the clipDistance varyings if geometry shaders are not used.
|
It works, awesome. |
Doing so causes the Adreno driver to choke and spew errors about too many output locations/components, when clearly we're under the limit.
|
Tested on desktop (NV), Adreno (OnePlus 6), and Mac. Fifoci says no differences, so that covers Mesa too. According to @zackhow, works fine on NV Shield TV. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken rendering on Adreno with Android 9-era drivers.
Apparently qcom isn't very good at allocating varying locations, and their compiler spews errors about exceeding the output component limit, when clearly we're not. This only happens if the varyings are defined in an interface block.
We don't need the interface block anyway, since these drivers don't support geometry shaders. So just generate the varying locations incrementally.
Also gets rid of a couple of varyings in scenarios where they're not used. I guess this will only make a difference if the drivers are really terrible at cross-stage optimization :)