Change Puppet[:user] and Puppet[:group] to those of the user running the test #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarod
force-pushed
the
change-puppet-user
branch
from
78fd336 to
6771bb6
Compare
mmarod
force-pushed
the
change-puppet-user
branch
from
36029f2 to
9d904e8
Compare
|
Any thoughts on this? |
|
This PR also fixes the problem for me. Having cloned and also applied this PR, the tests all pass (ruby 2.3.1). Is there a blocker to merging this and cutting a release? I note that the failing travis tests are for rubies 1.8 and 1.9. Aren't they both deprecated by puppet now> |
|
@nhemingway at what point can we just create a 0.5.0 on our own? The last release was over 3 years ago. |
|
Apologies, but I'm not tracking the module any more - I've changed jobs and
$newjob doesn't use puppet at all. It's a shame, cos it's a useful tool.
Neil
…On Fri, 6 Jul 2018 at 18:49, Bill Sirinek ***@***.***> wrote:
@nhemingway <https://github.com/nhemingway> at what point can we just
create a 0.5.0 on our own? The last release was over 3 years ago.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACqHBLH5sYLyyD-UeEc_wkAn_5PfV8dks5uD6MygaJpZM4EYz-M>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my fix for #15.
The problem seemed to boil down to the fact that Puppet[:user] and Puppet[:group] don't change to the running user during the apply. In this commit, I grab the user running the script and their primary group using Ruby's Etc module before the apply occurs.
It's a bit hacky but it gets me through the tests as non-root.