-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic when using rcrowley/go-metrics on Windows #1442
Comments
The problem reproduces for me on linux/amd64, running actual Linux, not WSL. |
Are you sure you're building Staticcheck with Go 1.21.0 when experiencing the crash? I can reproduce the crash with Go master (at ff00fdfdbeeb72ca8981a04290765452d6a31b26), but not with Go 1.21.0. Please include the output of |
This pulls in changes in go/packages that are necessary to return non-nil types.Sizes when using Go 1.22. Closes: gh-1442
Hey @dominikh, the releases you provide are built with Go 1.22-devel, it seems. When starting a clean Docker container and installing Go 1.21, I can still reproduce the crash that you fixed:
Can you cut a new release which includes the fix please, and/or build releases with the latest stable version of Go, not an unreleased version? Thanks :) |
Thanks for the quick fix! I can confirm it works for me now. |
I'm new to staticcheck and one of my projects causes a panic.
I managed to boil it down to a single file containing the following:
The issue doesn't occur if I switch to WSL (Ubuntu) and use the exact same staticcheck version (installed via Brew), so I guess this is a Windows specific issue.
The text was updated successfully, but these errors were encountered: