Handle importing invalid types (elastic#10666)

* show service errors but resolve promise

By handling service failures explicitely, the error doesn't bubble up the promise chain, so tasks
that have to happen after it, like refreshing the index and data, still happen, and the UI will
be in sync with the data in the .kibana index

* throw error on invalid saved object type

* append useful info to the type error message

src/core_plugins/kibana/public/management/sections/objects/_objects.js

@@ -197,12 +197,20 @@ uiModules.get('apps/management')
               return service.get()
                 .then(function (obj) {
                   obj.id = doc._id;
-                  return obj.applyESResp(doc).then(() => obj.save({ confirmOverwrite : !overwriteAll }));
-                });
-            })
-              .then(refreshIndex)
-              .then(refreshData)
-              .catch(notify.error);
+                  return obj.applyESResp(doc)
+                    .then(() => {
+                      return obj.save({ confirmOverwrite : !overwriteAll });
+                    })
+                    .catch((err) => {
+                      // swallow errors here so that the remaining promise chain executes
+                      err.message = `Importing ${obj.title} (${obj.id}) failed: ${err.message}`;
+                      notify.error(err);
+                    });
+                })
+                .then(refreshIndex)
+                .then(refreshData)
+                .catch(notify.error);
+            });
           });
       };
 

src/ui/public/vis/vis.js

@@ -83,8 +83,15 @@ export default function VisFactory(Notifier, Private) {
 
   Vis.prototype.setState = function (state) {
     this.title = state.title || '';
-    this.type = state.type || this.type;
-    if (_.isString(this.type)) this.type = visTypes.byName[this.type];
+    const type = state.type || this.type;
+    if (_.isString(type)) {
+      this.type = visTypes.byName[type];
+      if (!this.type) {
+        throw new Error(`Invalid type "${type}"`);
+      }
+    } else {
+      this.type = type;
+    }
 
     this.listeners = _.assign({}, state.listeners, this.type.listeners);
     this.params = _.defaults({},