Fix "data-title" attribute in map embeddable (elastic#88337)

dominiqueclarke · Jan 14, 2021 · f33225d · f33225d
1 parent d080128
commit f33225d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/x-pack/plugins/maps/public/embeddable/map_embeddable.tsx b/x-pack/plugins/maps/public/embeddable/map_embeddable.tsx
@@ -112,14 +112,20 @@ export class MapEmbeddable
       return;
     }
     this._initializeStore();
-    this._initializeOutput();
+    try {
+      await this._initializeOutput();
+    } catch (e) {
+      this.onFatalError(e);
+      return;
+    }
+
     this._isInitialized = true;
     if (this._domNode) {
       this.render(this._domNode);
     }
   }
 
-  private async _initializeStore() {
+  private _initializeStore() {
     const store = this._savedMap.getStore();
     store.dispatch(setReadOnly(true));
     store.dispatch(disableScrollZoom());

diff --git a/x-pack/test/functional/apps/maps/embeddable/dashboard.js b/x-pack/test/functional/apps/maps/embeddable/dashboard.js
@@ -55,6 +55,11 @@ export default function ({ getPageObjects, getService }) {
       return requestTimestamp;
     }
 
+    it('should set "data-title" attribute', async () => {
+      const [{ title }] = await PageObjects.dashboard.getPanelSharedItemData();
+      expect(title).to.be('join example');
+    });
+
     it('should pass index patterns to container', async () => {
       const indexPatterns = await filterBar.getIndexPatterns();
       expect(indexPatterns).to.equal('meta_for_geo_shapes*,logstash-*');