Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write only registered extensions from I/O #421

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

donmccurdy
Copy link
Owner

Extensions registered with I/O are written if used; unregistered extensions are skipped. For example, a Document with the Draco extension attached will be written uncompressed if the extension is not registered with I/O. Avoids some pathological cases where I/O can't handle the extension properly, and allows writing with a particular extension disabled, without deeper changes to the Document.

@donmccurdy donmccurdy added feature New enhancement or request package:extensions labels Nov 11, 2021
@donmccurdy donmccurdy added this to the v1.1 milestone Nov 11, 2021
@donmccurdy donmccurdy merged commit db422d0 into main Nov 11, 2021
@donmccurdy donmccurdy deleted the feat-write-registered-extensions branch November 11, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New enhancement or request package:extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant