Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle conflicting URIs during merge() #677

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Handle conflicting URIs during merge() #677

merged 1 commit into from
Sep 8, 2022

Conversation

donmccurdy
Copy link
Owner

Previously the merge CLI command would blindly overwrite textures with the same URI in the input files (e.g. a.gltf and b.gltf). Now it de-duplicates textures to ensure they aren't the same data, then ensures all textures have unique URIs.

@donmccurdy donmccurdy added bug Something isn't working package:cli labels Sep 8, 2022
@donmccurdy donmccurdy added this to the v2.4 milestone Sep 8, 2022
@donmccurdy donmccurdy merged commit 106cdbe into main Sep 8, 2022
@donmccurdy donmccurdy deleted the hotfix/merge-unique-texture-uris branch September 8, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:cli
Projects
None yet
Milestone
v2.4
Development

Successfully merging this pull request may close these issues.

CLI function "merge" is overwriting textures with the same name
1 participant
@donmccurdy