Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid requiring document as a function parameter unnecessarily #787

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Avoid requiring document as a function parameter unnecessarily #787

merged 2 commits into from
Jan 19, 2023

Conversation

donmccurdy
Copy link
Owner

Removes document from the following method signatures:

  • listTextureChannels(document, texture)
  • getTextureChannelMask(document, texture)
  • listTextureInfo(document, texture)
  • listTextureSlots(document, texture)

@donmccurdy
[functions] Avoid requiring document as a function parameter unnecess…
e71b798 
…arily.

Removes document from the following method signatures:

- listTextureChannels(texture)
- getTextureChannelMask(texture)
- listTextureInfo(texture)
- listTextureSlots(texture)
@donmccurdy donmccurdy added this to the v3.0 milestone Jan 19, 2023
@donmccurdy donmccurdy merged commit def1733 into main Jan 19, 2023
@donmccurdy donmccurdy deleted the feat/no-document-function-params branch January 19, 2023 15:06
@donmccurdy donmccurdy mentioned this pull request Jan 19, 2023
Closed
@donmccurdy
Copy link
Owner Author

Fixes #783.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code health package:functions
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@donmccurdy