Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sparse accessors #793

Merged
merged 9 commits into from
Jan 23, 2023
Merged

Add support for sparse accessors #793

merged 9 commits into from
Jan 23, 2023

Conversation

donmccurdy
Copy link
Owner

@donmccurdy donmccurdy commented Jan 20, 2023 •
edited
Loading

Remaining:

  • Unit tests
  • Handle sparse accessors containing only zero-filled elements
  • Add a transform, sparse(), to make accessors sparse, where appropriate
  • Add 'sparse' command to CLI
  • Verify that Draco compression skips sparse accessors
  • Verify that Meshopt compression skips sparse accessors
  • Verify that common transforms make accessors non-sparse, where appropriate

@donmccurdy donmccurdy added feature New enhancement or request package:core labels Jan 20, 2023
@donmccurdy donmccurdy added this to the v3.0 milestone Jan 20, 2023
@donmccurdy donmccurdy mentioned this pull request Jan 20, 2023
Closed
@donmccurdy
Fix zero-filled sparse accessors.
ed9265e
@donmccurdy
Add unit tests, fix support for zero-filled accessors.
6f2116a
@donmccurdy
Add sparse() transform
f4e9ef8
@donmccurdy
Add support for Draco compression on prims containing sparse vertex a…
7bcc405 
…ttributes

Note that the sparse accessors will _not_ be compressed, only fully-specified
attributes are included in draco compression.
@donmccurdy
Add support for Meshopt compression on prims containing sparse vertex…
73a9e15 
… attributes
@donmccurdy
Unset sparse accessors during quantize() and resample()
23761a6 
- resample() optimizes channels such that it's unlikely to be useful
- quantize() is currently incompatible, see #795
@donmccurdy
Copy link
Owner Author

One item left for future work:

@donmccurdy donmccurdy merged commit 672080b into main Jan 23, 2023
@donmccurdy donmccurdy deleted the feat/sparse branch January 23, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New enhancement or request package:core
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

Support writing sparse accessors
1 participant
@donmccurdy