Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more disadvantages of REST #9

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Add more disadvantages of REST #9

merged 2 commits into from
Mar 10, 2017
+2 −0

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented Mar 9, 2017

No description provided.

@yangshun
Add more disadvantages of REST

Verified

This commit was signed with the committer’s verified signature.
ctrlcctrlv Fredrick Brennan
GPG key ID: 5853056962F14E58
Verified
Learn about vigilant mode
838cc41
@luisbg
Copy link
Contributor

luisbg commented Mar 9, 2017

Nice. Good to mention the explosion of HTTP GETs that happens in a hierarchical REST API.

By the way, I think it should be "Fetching complicated resources with nested hierarchies requires [...]", since the requirement is the singular verb fetching and not the plural resources. An alternative would be to say "Fetching complicated resources with nested hierarchies that require [...]".

@yangshun
Copy link
Contributor Author

yangshun commented Mar 9, 2017

Thanks for the catch. Fixed the grammar.

@luisbg
Copy link
Contributor

luisbg commented Mar 9, 2017

My pleasure. This is a cool resource for System Design, happy to help make it even better.

@donnemartin donnemartin self-requested a review March 10, 2017 00:32
@donnemartin donnemartin merged commit b34e167 into donnemartin:master Mar 10, 2017
@donnemartin
Copy link
Owner

@yangshun @luisbg thank you!

donnemartin added a commit that referenced this pull request Mar 11, 2017
@donnemartin
Merge branch 'master' into develop
ebdb203 
* master:
  Add Dyn DDoS attack link (#13)
  Fix multiple typos (#14)
  Add more disadvantages of REST (#9)
  Fix typo - lobsided -> lopsided (#11)
  Fix typo in Study Guide section (#10)
  Fix #1: Update reverse proxy image (#8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnemartin donnemartin

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yangshun @luisbg @donnemartin