Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window path error #398

Merged
merged 29 commits into from
Jan 9, 2024
Merged

Fix window path error #398

merged 29 commits into from
Jan 9, 2024

Conversation

haixuanTao
Copy link
Collaborator

@haixuanTao haixuanTao commented Dec 20, 2023

Fix window path issue by using which::which (Cross Platform) to see if python3 is in path.

If python3 is not in path, try to use python alone.

Else it return an error with: failed to find pythonorpython3 in dora-daemon path. Make sure that python is available for the daemon

Put back windows test into the CI

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@haixuanTao haixuanTao force-pushed the fix-window-path-error branch from 8071261 to 6ef691d Compare January 8, 2024 16:09
@haixuanTao haixuanTao force-pushed the fix-window-path-error branch from 6ef691d to afcfec8 Compare January 8, 2024 16:20
@haixuanTao haixuanTao merged commit e35ed75 into main Jan 9, 2024
17 checks passed
@haixuanTao haixuanTao deleted the fix-window-path-error branch January 9, 2024 18:28
@haixuanTao haixuanTao mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants