-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix window path error #398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks a lot!
…ershell. This is required for python environment
phil-opp
approved these changes
Jan 3, 2024
haixuanTao
force-pushed
the
fix-window-path-error
branch
from
January 8, 2024 16:09
8071261
to
6ef691d
Compare
haixuanTao
force-pushed
the
fix-window-path-error
branch
from
January 8, 2024 16:20
6ef691d
to
afcfec8
Compare
Being able to download a file within a yaml declaration can later be integrated as a yaml feature. See: ultralytics/ultralytics#7432 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix window path issue by using
which::which
(Cross Platform) to see ifpython3
is in path.If python3 is not in path, try to use
python
alone.Else it return an error with:
failed to find
pythonor
python3in dora-daemon path. Make sure that python is available for the daemon
Put back windows test into the CI