Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dora cli renaming #399

Merged
merged 11 commits into from
Jan 2, 2024
Merged
22 changes: 11 additions & 11 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ jobs:

- name: "Check"
run: cargo check --all
- name: "Build"
run: cargo build --all
- name: "Build (Without Python node as it is build with maturin)"
run: cargo build --all --exclude dora-node-api-python
- name: "Test"
# Remove Windows as there is `pdb` linker issue.
# See: https://github.com/dora-rs/dora/pull/359#discussion_r1360268497
Expand Down Expand Up @@ -243,30 +243,30 @@ jobs:
# fail-fast by using bash shell explictly
shell: bash
run: |
dora-cli up
dora-cli list
dora up
dora list

# Test Rust template Project
dora-cli new test_rust_project --internal-create-with-path-dependencies
dora new test_rust_project --internal-create-with-path-dependencies
cd test_rust_project
cargo build --all
dora-cli start dataflow.yml --name ci-rust-test
dora start dataflow.yml --name ci-rust-test
sleep 10
dora-cli stop --name ci-rust-test
dora stop --name ci-rust-test
cd ..

# Test Python template Project
pip3 install maturin
maturin build -m apis/python/node/Cargo.toml
pip3 install target/wheels/*
dora-cli new test_python_project --lang python --internal-create-with-path-dependencies
dora new test_python_project --lang python --internal-create-with-path-dependencies
cd test_python_project
dora-cli start dataflow.yml --name ci-python-test
dora start dataflow.yml --name ci-python-test
sleep 10
dora-cli stop --name ci-python-test
dora stop --name ci-python-test
cd ..

dora-cli destroy
dora destroy

clippy:
name: "Clippy"
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
New-Item -Path archive -ItemType Directory
Copy-Item target/release/dora-coordinator.exe -Destination archive
Copy-Item target/release/dora-daemon.exe -Destination archive
Copy-Item target/release/dora-cli.exe -Destination archive/dora.exe
Copy-Item target/release/dora.exe -Destination archive/dora.exe
Compress-Archive -Path archive\* -DestinationPath archive.zip

- name: "Upload release asset"
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
mkdir archive
cp target/release/dora-coordinator archive
cp target/release/dora-daemon archive
cp target/release/dora-cli archive/dora
cp target/release/dora archive/dora
cd archive
zip -r ../archive.zip .
cd ..
Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
mkdir archive_aarch64
cp target/aarch64-unknown-linux-gnu/release/dora-coordinator archive_aarch64
cp target/aarch64-unknown-linux-gnu/release/dora-daemon archive_aarch64
cp target/aarch64-unknown-linux-gnu/release/dora-cli archive_aarch64/dora
cp target/aarch64-unknown-linux-gnu/release/dora archive_aarch64/dora
cd archive_aarch64
zip -r ../archive_aarch64.zip .
cd ..
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
mkdir archive_aarch64
cp target/aarch64-apple-darwin/release/dora-coordinator archive_aarch64
cp target/aarch64-apple-darwin/release/dora-daemon archive_aarch64
cp target/aarch64-apple-darwin/release/dora-cli archive_aarch64/dora
cp target/aarch64-apple-darwin/release/dora archive_aarch64/dora
cd archive_aarch64
zip -r ../archive_aarch64.zip .
cd ..
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ Quickest way:

```bash
cargo install dora-cli
alias dora='dora-cli'
cargo install dora-coordinator
cargo install dora-daemon
pip install dora-rs ## For Python API
Expand Down
2 changes: 1 addition & 1 deletion apis/python/node/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ dora-ros2-bridge-python = { workspace = true }

[lib]
name = "dora"
crate-type = ["lib", "cdylib"]
crate-type = ["cdylib"]
2 changes: 1 addition & 1 deletion binaries/cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ license.workspace = true
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[[bin]]
name = "dora-cli"
name = "dora"
path = "src/main.rs"

[features]
Expand Down
2 changes: 1 addition & 1 deletion libraries/arrow-convert/src/from_impls.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use arrow::{
array::{make_array, Array, AsArray, PrimitiveArray, StringArray},
array::{Array, AsArray, PrimitiveArray, StringArray},
datatypes::ArrowPrimitiveType,
};
use eyre::ContextCompat;
Expand Down
Loading