-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow top-level fields in node declaration #478
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
4 tasks
phil-opp
force-pushed
the
dataflow-parsing
branch
2 times, most recently
from
May 22, 2024 12:39
d7ffbe9
to
8c1412e
Compare
We plan to (soft-)remove operators and simplify the dataflow YAML file by removing the additional nesting caused by the `custom` field. This commit prepares for that. See #474 for context.
We want to treat the nodes like custom nodes in this case since we plan to deprecate operators.
phil-opp
force-pushed
the
dataflow-parsing
branch
from
May 22, 2024 12:39
8c1412e
to
ae13505
Compare
phil-opp
force-pushed
the
dataflow-parsing
branch
from
May 22, 2024 12:50
ae13505
to
f850980
Compare
haixuanTao
reviewed
May 22, 2024
haixuanTao
approved these changes
May 22, 2024
haixuanTao
reviewed
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you actually run
cargo run -p dora-core generate_schemas
To regenerate the JSON Schema.
Maybe I should have put a script to do this automatically
I regenerated the schemas in 7364860. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to deprecate operators in their current form in a future release. This PR implements the proposed new syntax for declaring custom nodes without an extra level of nesting:
The
inputs
/outputs
/etc fields are now directly declared next to theid
field, instead of being nested under acustom
field. Thesource
field was renamed topath
as discussed in our last meeting.TODO:
path
alias tocustom->source
field to allow both names.