Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path checks for nodes on remote machines #534

Closed
wants to merge 1 commit into from

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Jun 5, 2024

  • don't check paths for remote nodes
  • ensure that paths of of remote nodes are absolute

- don't check paths for remote nodes
- ensure that paths of of remote nodes are absolute
@phil-opp phil-opp requested a review from haixuanTao June 5, 2024 16:32
@phil-opp
Copy link
Collaborator Author

phil-opp commented Jun 5, 2024

The "paths on remote machines must be absolute" rule is probably a bit too limiting and it makes it difficult to commit things to git. So it's probably a better idea to use a default working directory as proposed in #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant