Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alignment of atomics in shared memory communication channel #612

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Fix alignment of atomics in shared memory communication channel #612

merged 2 commits into from
Aug 9, 2024

Conversation

phil-opp
Copy link
Collaborator

@phil-opp phil-opp commented Aug 7, 2024

Fixes #610

@phil-opp phil-opp mentioned this pull request Aug 7, 2024
Closed
@Hennzau Hennzau marked this pull request as ready for review August 7, 2024 12:11
@Hennzau Hennzau marked this pull request as draft August 7, 2024 12:14
@phil-opp phil-opp marked this pull request as ready for review August 8, 2024 12:03
@phil-opp phil-opp requested a review from haixuanTao August 8, 2024 12:03
haixuanTao
haixuanTao approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@haixuanTao haixuanTao merged commit 38fb28f into main Aug 9, 2024
40 checks passed
@haixuanTao haixuanTao deleted the fix-shmem-channel-alignment branch August 9, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoliv taoliv taoliv left review comments

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unaligned shmem access on aarch64
3 participants
@phil-opp @haixuanTao @taoliv