fix clippy warnings #626
Merged
fix clippy warnings #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm including this in a seaparate commit to call attention to it, in case the same return value is itself a bug.
Michael-J-Ward
force-pushed
the
clippy-lints
branch
from
5cd5469 to
011d610
Compare
haixuanTao
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching up on the all the work you've been doing, and thought I'd throw this simple one up to clean up the clippy warnings.
I'd like to call attention to this commit because I suspect returning the same value from each side of the
if encoding == "bgr8"could actually be a bug.39c71bf