Skip to content

Commit

Permalink
Merge pull request #331 from doronz88/refactor/ci
Browse files Browse the repository at this point in the history
ci: optimize pull-request actions
  • Loading branch information
doronz88 authored Dec 13, 2023
2 parents f1981ba + 4e1d489 commit 4238f36
Show file tree
Hide file tree
Showing 4 changed files with 145 additions and 152 deletions.
74 changes: 0 additions & 74 deletions .github/workflows/macos-pytest.yml

This file was deleted.

145 changes: 145 additions & 0 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,145 @@
# This workflow will install Python dependencies, run tests and lint with a single version of Python
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions

name: pull request

on:
pull_request:
branches: [ "master" ]

jobs:
python-app:
if: '! github.event.pull_request.draft'
runs-on: ubuntu-latest

defaults:
run:
working-directory: ./src/rpcclient

strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: [ 3.8, 3.9, "3.10", 3.11, 3.12 ]

steps:
- uses: actions/checkout@v3
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Lint with flake8
run: |
python -m pip install flake8
flake8 . --max-complexity=14 --max-line-length=127 --statistics
- name: Verify sorted imports
run: |
python -m pip install isort
isort . -m HANGING_INDENT -l 120 --check-only
- name: Build
# TODO: remove when lief releases the 3.12 wheel (https://github.com/lief-project/LIEF/issues/990)
if: matrix.python-version != 3.12
run: |
python -m pip install build
python3 -m build
- name: Install
# TODO: remove when lief releases the 3.12 wheel (https://github.com/lief-project/LIEF/issues/990)
if: matrix.python-version != 3.12
run: |
python3 -m pip install .
- name: Run help
# TODO: remove when lief releases the 3.12 wheel (https://github.com/lief-project/LIEF/issues/990)
if: matrix.python-version != 3.12
run: |
python3 -m rpcclient --help
build-linux-server:
if: '! github.event.pull_request.draft'
runs-on: ${{ matrix.os }}

defaults:
run:
working-directory: ./src/rpcserver

strategy:
matrix:
include:
- os: ubuntu-latest
arch: aarch64
- os: ubuntu-latest
arch: i686
- os: ubuntu-latest
arch: x86_64

steps:
- uses: actions/checkout@v3
- name: Test make
run: |
make clean all
pytest:
if: '! github.event.pull_request.draft'
needs: [python-app, build-linux-server]
runs-on: ${{ matrix.os }}

defaults:
run:
working-directory: .

strategy:
matrix:
include:
- os: macos-latest
arch: arm64
python-version: "3.8"
- os: macos-latest
arch: arm64
python-version: "3.9"
- os: macos-latest
arch: arm64
python-version: "3.10"
- os: macos-latest
arch: arm64
python-version: "3.11"
# TODO: remove when lief releases the 3.12 wheel (https://github.com/lief-project/LIEF/issues/990)
# - os: macos-latest
# arch: arm64
# python-version: "3.12"

- os: macos-latest
arch: x86_64
python-version: "3.8"
- os: macos-latest
arch: x86_64
python-version: "3.9"
- os: macos-latest
arch: x86_64
python-version: "3.10"
- os: macos-latest
arch: x86_64
python-version: "3.11"
# TODO: remove when lief releases the 3.12 wheel (https://github.com/lief-project/LIEF/issues/990)
# - os: macos-latest
# arch: x86_64
# python-version: "3.12"

steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Run server
working-directory: ./src/rpcserver
run: |
make SERVER_CFLAGS=-DSAFE_READ_WRITES
sudo nohup ./rpcserver &
- name: Install python package + pytest
working-directory: ./src/rpcclient
run: |
python -m pip install --upgrade pip
python -m pip install -U pytest
python -m pip install -U .
- name: pytest
working-directory: ./src/rpcclient
run: |
python -m pytest --ci --local-machine
44 changes: 0 additions & 44 deletions .github/workflows/python-app.yml

This file was deleted.

34 changes: 0 additions & 34 deletions .github/workflows/server-app.yml

This file was deleted.

0 comments on commit 4238f36

Please sign in to comment.