This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
dotCMS/core#21122 Replace What's changed with the htmldiff js library #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please add screenshots of the empty state here. |
fmontes
suggested changes
Jan 25, 2022
Comment on lines
40
to
59
| this.dotEditPageService | ||
| .whatChange(this.pageId, this.languageId) | ||
| .pipe(take(1)) | ||
| .subscribe((data) => { | ||
| this.whatsChanged = data; | ||
| if (this.whatsChanged.diff) { | ||
| const doc = this.getEditPageDocument(); | ||
| doc.open(); | ||
| doc.write( | ||
| this.updateHtml( | ||
| this.dotDiffPipe.transform( | ||
| this.whatsChanged.renderLive, | ||
| this.whatsChanged.renderWorking | ||
| ) | ||
| ) | ||
| ); | ||
| doc.head.appendChild(this.styles); | ||
| doc.close(); | ||
| } | ||
| }); |
fmontes
approved these changes
Jan 27, 2022
fmontes
added a commit
that referenced
this pull request
Jan 31, 2022
* update release version for dotcms-ui & dotcms-webcomponents * CI: bumps version to 22.2.0-rc.2 [skip ci] * dotCMS/core#21504 Template designer: container selector breaks while there are "Unsave Changes" * CI: bumps version to 22.2.0-rc.2 [skip ci] * dotCMS/core#21436 Enable the bring back button (#1846) * CI: bumps version to 22.2.0-rc.3 [skip ci] * dotCMS/core#21540 Add a form from the Contentlet palette in edit page is not working * CI: bumps version to 22.2.0-rc.4 [skip ci] * dotCMS/core#21122 Replace What's changed with the htmldiff js library (#1855) * replace backend library * cleanup * tests * cleanup * error handler * CI: bumps version to 22.2.0-rc.5 [skip ci] * dotCMS/core#21600 Remove "Unsaved changes" from auto saving * dotCMS/core#21240 Show global message on inline editing (#1861) * dotCMS/core #21436 Prevent the redirect of the page when we are in edit mode * CI: bumps version to 22.2.0-rc.6 [skip ci] * Fix tests * CI: bumps version to 22.3.0-next.9 [skip ci] Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Humberto Morera <[email protected]>
fmontes
added a commit
that referenced
this pull request
Feb 10, 2022
* update release version for dotcms-ui & dotcms-webcomponents * CI: bumps version to 22.2.0-rc.2 [skip ci] * dotCMS/core#21504 Template designer: container selector breaks while there are "Unsave Changes" * CI: bumps version to 22.2.0-rc.2 [skip ci] * dotCMS/core#21436 Enable the bring back button (#1846) * CI: bumps version to 22.2.0-rc.3 [skip ci] * dotCMS/core#21540 Add a form from the Contentlet palette in edit page is not working * CI: bumps version to 22.2.0-rc.4 [skip ci] * dotCMS/core#21122 Replace What's changed with the htmldiff js library (#1855) * replace backend library * cleanup * tests * cleanup * error handler * CI: bumps version to 22.2.0-rc.5 [skip ci] * dotCMS/core#21600 Remove "Unsaved changes" from auto saving * dotCMS/core#21240 Show global message on inline editing (#1861) * dotCMS/core #21436 Prevent the redirect of the page when we are in edit mode * CI: bumps version to 22.2.0-rc.6 [skip ci] * dotCMS/core#21599 Push Publishing Workflow Dialog is missing timezoneId * CI: bumps version to 22.2.0-rc.7 [skip ci] * dotCMS/core#21552 Avoid trigger the original form submit event (#1862) * dotCMS/core#21552 Add forms from content palette error (#1868) * initial progress * cleanup * test updates * test updates * feedback * rename functions * CI: bumps version to 22.2.0-rc.8 [skip ci] * dotCMS/core#21656 Once a fileAsset is saved. the file itself can not be replaced using Save (#1872) * CI: bumps version to 22.2.0-rc.3 [skip ci] * dotCMS/core#21558 Edit Template Properties Modal makes changes get lost (#1865) * fix: Must supply a value for form control with name: 'title' * remove dot-template store service from Dot Template Advanced Component * fix: Edit Template Properties Modal makes changes get lost on advance template * fix: Edit Template Properties Modal makes changes get lost on design template * update template design * clean up * feedback * clean up * fix dot-template store tests * fix tests on dot-template-create-edit * fix dot-template-builder tests * fix dot-template tests * fix DotEditLayoutComponent * clean up * rename saveDraft to updateTemplate * add docs * feedback * feedback * clean up * feedback * clean up * fix doc * CI: bumps version to 22.2.0-rc.9 [skip ci] * Update package * Update package-lock * Clean up * Fix conflicts * CI: bumps version to 22.3.0-next.13 [skip ci] Co-authored-by: victoralfaro-dotcms <[email protected]> Co-authored-by: Rafael Velazco <[email protected]> Co-authored-by: Humberto Morera <[email protected]> Co-authored-by: Freddy Rodriguez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
Empty State: