This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
Add State Management to palette #21507 #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rjvelazco
previously approved these changes
Jan 25, 2022
hmoreras
suggested changes
Jan 26, 2022
| return { ...state, filter: data }; | ||
| }); | ||
|
|
||
| readonly languageId = this.updater((state: DotPaletteState, data: string) => { |
There was a problem hiding this comment.
updateLanguage or setLanguageId
| return { ...state, languageId: data }; | ||
| }); | ||
|
|
||
| readonly viewContentlet = this.updater((state: DotPaletteState, data: string) => { |
alfredo-dotcms
force-pushed
the
issue-21507-Dot-Palette-add-state-management
branch
from
5ce0c10 to
da3326a
Compare
fmontes
suggested changes
Jan 27, 2022
Comment on lines
60
to
62
| this.store.setViewContentlet(viewContentlet); | ||
| this.store.setFilter(''); | ||
| this.store.loadContentlets(variableName); |
There was a problem hiding this comment.
Suggested change
| this.store.setViewContentlet(viewContentlet); | |
| this.store.setFilter(''); | |
| this.store.loadContentlets(variableName); | |
| this.store.switchView(...); |
And do all the other things internally? We only call all those here.
Comment on lines
129
to
144
| readonly vm$ = this.select( | ||
| this.contentlets$, | ||
| this.contentTypes$, | ||
| this.filter$, | ||
| this.totalRecords$, | ||
| this.viewContentlet$, | ||
| this.loading$, | ||
| (contentlets, contentTypes, filter, totalRecords, viewContentlet, loading) => ({ | ||
| contentlets, | ||
| contentTypes, | ||
| filter, | ||
| totalRecords, | ||
| viewContentlet, | ||
| loading | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Remove all the selectors that are not being used and just use the full state object if you want to skip lang id cool, but I would just send it.
fmontes
suggested changes
Jan 28, 2022
Comment on lines
175
to
184
| readonly switchView = this.effect((variableName$: Observable<string>) => { | ||
| return variableName$.pipe( | ||
| map((variableName: string) => { | ||
| const viewContentlet = variableName ? 'contentlet:in' : 'contentlet:out'; | ||
| this.setViewContentlet(viewContentlet); | ||
| this.setFilter(''); | ||
| this.loadContentlets(variableName); | ||
| }) | ||
| ); | ||
| }); |
fmontes
approved these changes
Jan 28, 2022
hmoreras
approved these changes
Jan 28, 2022
delete-merged-branch
bot
deleted the
issue-21507-Dot-Palette-add-state-management
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
we need to add State Management to our Content Reuse Palette
Checklist
Additional Info
** any additional useful context or info **
Screenshots