This repository has been archived by the owner on Dec 16, 2024. It is now read-only.
dotCMS/core#22104 fix dot-md-icon-selector-being-activated-on-form-submit #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmoreras
approved these changes
May 3, 2022
fmontes
suggested changes
May 3, 2022
| @@ -210,6 +210,7 @@ export class DotMaterialIcon { | |||
| <button | |||
| class="dot-material-icon__button" | |||
| role="button" | |||
| type="button" | |||
There was a problem hiding this comment.
A) Does this fix this behavior in the copy content type as well?
B) Do we have to do extra work every time we use this web component in a form?
fmontes
approved these changes
May 3, 2022
delete-merged-branch
bot
deleted the
issue-22104-dot-md-icon-selector-being-activated-on-form-submit
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you are creating/ copying a content type and you press the enter key, we are moving to the icon field and not creating the new content type directly.
Checklist
Additional Info
** any additional useful context or info **
Screenshots