#13309 - MSSQL Upsert SQL

dotCMS · Jan 5, 2018 · 13c33af · 13c33af
1 parent de84e31
commit 13c33af
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/dotCMS/src/main/java/com/dotmarketing/business/PermissionBitFactoryImpl.java b/dotCMS/src/main/java/com/dotmarketing/business/PermissionBitFactoryImpl.java
@@ -2305,6 +2305,14 @@ private void deleteInsertPermission(Permissionable permissionable, String type,
 					dc1.executeUpdate(query, permissionId, newReference.getPermissionId(), type,
 							permissionId, newReference.getPermissionId(), type);
 				}
+				if (DbConnectionFactory.isMsSql()) {
+					String query = SQLUtil.generateUpsertSQL("permission_reference", "asset_id", "?",
+							new String[]{"asset_id", "reference_id", "permission_type"},
+							new String[]{"?", "?", "?"});
+					dc1.executeUpdate(query, permissionId, permissionId,
+							permissionId, newReference.getPermissionId(), type,
+							permissionId, newReference.getPermissionId(), type);
+				}
             }
 
         } catch(Exception exception){

diff --git a/dotCMS/src/main/java/com/dotmarketing/common/util/SQLUtil.java b/dotCMS/src/main/java/com/dotmarketing/common/util/SQLUtil.java
@@ -24,6 +24,7 @@
 import net.sourceforge.squirrel_sql.plugins.mysql.tokenizer.MysqlQueryTokenizer;
 import net.sourceforge.squirrel_sql.plugins.oracle.prefs.OraclePreferenceBean;
 import net.sourceforge.squirrel_sql.plugins.oracle.tokenizer.OracleQueryTokenizer;
+import org.quartz.utils.DBConnectionManager;
 
 /**
  * Util class for sanitize, tokenize, etc
@@ -319,6 +320,14 @@ private static boolean isValidSQLCharacter (final char c) {
 			"INSERT INTO %s (%s) "
 			+ "VALUES (%s) ON DUPLICATE KEY "
 			+ "UPDATE %s";
+	private final static String MSSQL_UPSERT_QUERY =
+			"MERGE INTO %s USING "
+			+ "(SELECT %s [conditional]) AS dummy([conditional]) ON %s = %s "
+			+ "WHEN MATCHED THEN "
+			+ "  UPDATE SET %s "
+			+ "WHEN NOT MATCHED THEN "
+			+ "  INSERT (%s) "
+			+ "  VALUES (%s);";
 
 	public static String generateUpsertSQL (String table, String conditionalColumn, String conditionalValue, String[] columns, String[] values) {
 		String query = null;
@@ -345,6 +354,15 @@ public static String generateUpsertSQL (String table, String conditionalColumn,
 					StringUtil.merge(values),
 					buffer.toString());
 		}
+		if (DbConnectionFactory.isMsSql()) {
+			query = String.format(MSSQL_UPSERT_QUERY, table,
+					conditionalValue,
+					conditionalColumn,
+					conditionalValue,
+					buffer.toString(),
+					StringUtil.merge(columns),
+					StringUtil.merge(values));
+		}
 
 		return query;
 	}