feat(edit-content) type fixes

dotCMS · Jan 26, 2024 · c679c46 · c679c46
1 parent d397faf
commit c679c46
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 25 deletions.
diff --git a/core-web/libs/data-access/src/lib/dot-temp-file-upload/dot-temp-file-upload.service.ts b/core-web/libs/data-access/src/lib/dot-temp-file-upload/dot-temp-file-upload.service.ts
@@ -7,17 +7,7 @@ import { catchError, map, pluck, take } from 'rxjs/operators';
 
 import { DotHttpErrorManagerService } from '@dotcms/data-access';
 import { CoreWebService } from '@dotcms/dotcms-js';
-
-export interface DotCMSTempFile {
-    fileName: string;
-    folder: string;
-    id: string;
-    image: boolean;
-    length: number;
-    mimeType: string;
-    referenceUrl: string;
-    thumbnailUrl: string;
-}
+import { DotCMSTempFile } from '@dotcms/dotcms-models';
 
 @Injectable()
 export class DotTempFileUploadService {

diff --git a/.../lib/fields/dot-edit-content-binary-field/dot-edit-content-binary-field.component.spec.ts b/.../lib/fields/dot-edit-content-binary-field/dot-edit-content-binary-field.component.spec.ts
@@ -16,12 +16,8 @@ import { By } from '@angular/platform-browser';
 import { ButtonModule } from 'primeng/button';
 import { DialogModule } from 'primeng/dialog';
 
-import {
-    DotCMSTempFile,
-    DotLicenseService,
-    DotMessageService,
-    DotUploadService
-} from '@dotcms/data-access';
+import { DotLicenseService, DotMessageService, DotUploadService } from '@dotcms/data-access';
+import { DotCMSTempFile } from '@dotcms/dotcms-models';
 import { DotEditContentBinaryFieldComponent } from '@dotcms/edit-content';
 import { DropZoneErrorType, DropZoneFileEvent } from '@dotcms/ui';
 import { dotcmsContentletMock } from '@dotcms/utils-testing';
@@ -144,7 +140,7 @@ describe('DotEditContentBinaryFieldComponent', () => {
             spectator.detectChanges();
         });
 
-        it('should show dropzone when statust is INIT', () => {
+        it('should show dropzone when status is INIT', () => {
             expect(spectator.query('dot-drop-zone')).toBeTruthy();
         });
 
@@ -229,11 +225,11 @@ describe('DotEditContentBinaryFieldComponent', () => {
 
         it('should remove file and set INIT status when remove file ', async () => {
             const spyRemoveFile = jest.spyOn(store, 'removeFile');
-            const dotBinarPreviewFile = spectator.fixture.debugElement.query(
+            const dotBinaryPreviewFile = spectator.fixture.debugElement.query(
                 By.css('[data-testId="preview"]')
             );
 
-            dotBinarPreviewFile.componentInstance.removeFile.emit();
+            dotBinaryPreviewFile.componentInstance.removeFile.emit();
 
             store.vm$.subscribe((state) => {
                 expect(state).toEqual({
@@ -345,7 +341,7 @@ describe('DotEditContentBinaryFieldComponent', () => {
             expect(spySetMode).toHaveBeenCalledWith(BinaryFieldMode.EDITOR);
         });
 
-        it('should open dialog with url componet component when click on url button', async () => {
+        it('should open dialog with url component component when click on url button', async () => {
             const spySetMode = jest.spyOn(store, 'setMode');
             const urlBtn = spectator.query(byTestId('action-url-btn')) as HTMLButtonElement;
             urlBtn.click();
@@ -420,7 +416,7 @@ class MockFormComponent {
     });
 }
 
-describe('DotEditContentBinaryFieldComponent - ControlValueAccesor', () => {
+describe('DotEditContentBinaryFieldComponent - ControlValueAccessor', () => {
     let spectator: SpectatorHost<DotEditContentBinaryFieldComponent, MockFormComponent>;
     const createHost = createHostFactory({
         component: DotEditContentBinaryFieldComponent,
@@ -441,7 +437,7 @@ describe('DotEditContentBinaryFieldComponent - ControlValueAccesor', () => {
     });
 
     it('should set form value when binary file changes', () => {
-        // Call the onChange method from ControlValueAccesor
+        // Call the onChange method from ControlValueAccessor
         spectator.component.setTempFile(TEMP_FILE_MOCK);
         const formValue = spectator.hostComponent.form.get('binaryField').value; // Get the form value
         expect(formValue).toBe(TEMP_FILE_MOCK.id); // Check if the form value was set

diff --git a/core-web/libs/edit-content/src/lib/fields/dot-edit-content-binary-field/utils/mock.ts b/core-web/libs/edit-content/src/lib/fields/dot-edit-content-binary-field/utils/mock.ts
@@ -1,4 +1,3 @@
-import { FileMetaData } from '@dotcms/data-access';
 import { DotCMSTempFile } from '@dotcms/dotcms-models';
 import { MockDotMessageService } from '@dotcms/utils-testing';
 
@@ -138,7 +137,7 @@ export const CONTENTLET = {
     variant: 'DEFAULT'
 };
 
-export const fileMetaData: FileMetaData = {
+export const fileMetaData = {
     contentType: 'image/png',
     fileSize: 12312,
     length: 12312,