#13469 codacy feedback

dotCMS · Jan 26, 2018 · e25d04c · e25d04c
1 parent 7a606ec
commit e25d04c
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 7 deletions.
diff --git a/dotCMS/src/main/java/com/dotcms/workflow/helper/WorkflowHelper.java b/dotCMS/src/main/java/com/dotcms/workflow/helper/WorkflowHelper.java
@@ -34,7 +34,6 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
-import java.util.stream.IntStream;
 
 import static com.dotmarketing.db.HibernateUtil.addSyncCommitListener;
 

diff --git a/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java b/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowAPIImpl.java
@@ -147,7 +147,7 @@ public boolean existSchemeIdOnSchemesList(String schemeId, List<WorkflowScheme>
 		return workFlowFactory.existSchemeIdOnSchemesList(schemeId, schemes);
 	}
 
-	public WorkflowTask findTaskById(String id) throws DotDataException {
+	public WorkflowTask findTaskById(final String id) throws DotDataException {
 		return workFlowFactory.findWorkFlowTaskById(id);
 	}
 

diff --git a/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowFactoryImpl.java b/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/business/WorkflowFactoryImpl.java
@@ -1386,7 +1386,7 @@ private String getStringValue(Map<String, Object> row, String key) {
 	}
 
 	private Long getLongValue(final Map<String, Object> row, final String key) {
-		return ConversionUtils.toLong(row.get(key), 0l);
+		return ConversionUtils.toLong(row.get(key), 0L);
 	}
 	// christian escalation
 	public List<WorkflowTask> searchAllTasks(WorkflowSearcher searcher) throws DotDataException {

diff --git a/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/model/WorkflowTask.java b/dotCMS/src/main/java/com/dotmarketing/portlets/workflows/model/WorkflowTask.java
@@ -143,7 +143,7 @@ public long getLanguageId() {
         return languageId;
     }
 
-    public void setLanguageId(long languageId) {
+    public void setLanguageId(final long languageId) {
         this.languageId = languageId;
     }
 

diff --git a/.../main/java/com/dotmarketing/startup/runonce/Task04330WorkflowTaskAddLanguageIdColumn.java b/.../main/java/com/dotmarketing/startup/runonce/Task04330WorkflowTaskAddLanguageIdColumn.java
@@ -2,9 +2,6 @@
 
 package com.dotmarketing.startup.runonce;
 
-import static com.dotcms.util.CollectionsUtils.*;
-
-import com.dotcms.util.CollectionsUtils;
 import com.dotcms.util.ConversionUtils;
 import com.dotmarketing.common.db.DotConnect;
 import com.dotmarketing.db.DbConnectionFactory;
@@ -22,6 +19,8 @@
 import java.util.List;
 import java.util.Map;
 
+import static com.dotcms.util.CollectionsUtils.map;
+
 /**
  * This upgrade task will add the column language_id to the workflow_task, set the default language id to all of current records
  * and add an index for the language_id.