Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect Velocity Folder config property #11303

Closed
dsilvam opened this issue Apr 12, 2017 · 2 comments
Closed

Respect Velocity Folder config property #11303

dsilvam opened this issue Apr 12, 2017 · 2 comments
Assignees
@DeanGonzalez
Labels
Doc : Documented Merged QA : Approved Release : 4.1.0
Milestone
4.1_05122017_Rex

Comments

@dsilvam
Copy link
Contributor

dsilvam commented Apr 12, 2017

Description by @wezell :

There is another requirement - we need to respect theVELOCITY_FOLDER config property everywhere within the dotCMS system. Currently, our ActivatorUtil has this value hard coded. Here is a search of where we need to change this property to use what is configured in the config properties:

af6ad926-1f92-11e7-9fe2-fd537afbf399
@dsilvam dsilvam added this to the Rex Current milestone Apr 12, 2017
danlaguna pushed a commit that referenced this issue Apr 18, 2017
#11303: Get Velocity root folder method created. Classes that had the…
9507077 
… hardcoded path were modified.
@danlaguna danlaguna removed their assignment Apr 18, 2017
@dsilvam dsilvam mentioned this issue Apr 18, 2017
Closed
@dsilvam dsilvam modified the milestones: Rex Next, Rex Current Apr 18, 2017
This was referenced Apr 24, 2017
Closed
Closed
Closed
dsilvam pushed a commit that referenced this issue Apr 28, 2017
@danlaguna @dsilvam
#11303: Get Velocity root folder method created. Classes that had the… (
dc47dca 
#11335)

* #11303: Get Velocity root folder method created. Classes that had the hardcoded path were modified.

* #10370: Final adjustments to Velocity folder capabilities. Use the VELOCITY_ROOT property to override the default path
@dsilvam dsilvam added the Merged label Apr 28, 2017
danlaguna pushed a commit that referenced this issue Apr 28, 2017
#11303: Unit test modified so it restablishes the default property of…
290b84f 
… VELOCITY_ROOT, required for other tests.
dsilvam pushed a commit that referenced this issue Apr 28, 2017
@danlaguna @dsilvam
#11303: Unit test modified so it restablishes the default property of…
d6dbd93 
… VELOCITY_ROOT, required for other tests. (#11438)
@shaydotcms shaydotcms self-assigned this May 1, 2017
danlaguna pushed a commit that referenced this issue May 1, 2017
#11303: Fixing JUnit logic to preserve original value
6944edb
danlaguna pushed a commit that referenced this issue May 1, 2017
#11303: Fixing Junit logic
7d9c0f4
danlaguna pushed a commit that referenced this issue May 1, 2017
#11303: Verify original root is successfully reestablished
563d69e
dsilvam pushed a commit that referenced this issue May 1, 2017
@danlaguna @dsilvam
Issue 11303 fixing junit logic (#11449)
6f6acfd 
* #11303: Fixing JUnit logic to preserve original value

* #11303: Fixing Junit logic

* #11303: Verify original root is successfully reestablished
@shaydotcms
Copy link

Passed QA

  • Verified that velocity default folder location is created when velocity property is not defined in dotmarketing-config.properties. Uploaded successfully osgi plugin.
  • Verified that velocity custom folder is created when velocity property is defined (VELOCITY_ROOT) in dotmarketing-config.properties. Uploaded successfully osgi plugin.
  • Verified that velocity custom folder is created when defining an environment variable and velocity property (VELOCITY_ROOT) is defined in dotmarketing-config.properties (e.g.: VELOCITY_ROOT = {env:velocityPath). Uploaded successfully osgi plugin.
  • Uploaded a few osgi plugins and worked fine.

Tested in dotcms 4.1.0 distribution
Mac OS 10.10 / MySQL 5.6.35 / Firefox v45.0.1 / Tomcat 8 / Java 8

@shaydotcms shaydotcms removed their assignment May 2, 2017
@DeanGonzalez DeanGonzalez self-assigned this May 10, 2017
@DeanGonzalez
Copy link

Documented: https://auth.dotcms.com/docs/latest/distributed-velocity-files

@wezell wezell closed this as completed May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeanGonzalez DeanGonzalez

Labels
Doc : Documented Merged QA : Approved Release : 4.1.0
Projects
None yet
Milestone
4.1_05122017_Rex
Development

No branches or pull requests
5 participants
@wezell @DeanGonzalez @dsilvam @shaydotcms @danlaguna