Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listing-data-table.component and add action to delete content type #12758

Closed
fmontes opened this issue Oct 4, 2017 · 4 comments
Closed

Comments

@fmontes
Copy link
Member

fmontes commented Oct 4, 2017

listing table

About listing page

So we can have 2 options of listing table:

  1. User can't select rows
  2. User can select more than one row using the checkbox

So rows without checkboxes we need to add actions

We need to update the listing-data-table.component

  1. Add a array param to pass actions for rows, (we can use the interface for MenuItem of primeng)
  2. If the user pass an array with just one action we show directly the icon with a tooltip button
  3. If the user pass an array of actions that have more than one options we use the ... icon button with the menu of options.

Components

  1. One action component: Update the icon with a tooltip component to be accesible and use the icon button under the hood.
  2. More than one action component: Create a new button action component that is a combination of icon button with the menu of options.

Acceptance Criteria

  1. Match the design
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
  5. Implement the delete content type action on the content type listing.
@fmontes fmontes added this to the Fox Current milestone Oct 4, 2017
@fmontes fmontes modified the milestones: Fox Current, Fox Next Oct 16, 2017
@luisrojascr luisrojascr self-assigned this Oct 23, 2017
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Oct 30, 2017
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Oct 30, 2017
@fmontes fmontes modified the milestones: Fox Current, Fox Next Oct 30, 2017
@fmontes fmontes changed the title Update listing-data-table.component to receive actions Update listing-data-table.component and add action to delete content type Oct 30, 2017
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Oct 31, 2017
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Oct 31, 2017
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Oct 31, 2017
fmontes pushed a commit to dotCMS/core-web that referenced this issue Nov 2, 2017
@bryanboza
Copy link
Contributor

For QA: The description of this card is about the listing-data-table.component, not related to content types portlet, this is a global component that can be reused in multiple portlets.

@bryanboza
Copy link
Contributor

New related card reported here #12991

Now @wezell, @fishsmith since we don't have right click action on this new angular portlets, not sure if by default we should include the edit action on this table or not. We can edit just clicking the content type, but we also have this option in the old one.

FYI: Right now we just have the delete action by default

@bryanboza
Copy link
Contributor

After test that, when you configure the push environment we have just the Push Publish option on this menu, we lost the "Add to bundle" option.

SC: https://screencast.com/t/tdYFZHWC

@bryanboza
Copy link
Contributor

That's an old issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants