Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sidebar width in the edit layout page #13295

Closed
fmontes opened this issue Jan 3, 2018 · 2 comments
Closed

Set sidebar width in the edit layout page #13295

fmontes opened this issue Jan 3, 2018 · 2 comments
Assignees

Comments

@fmontes
Copy link
Member

fmontes commented Jan 3, 2018

As a user I want to be able to set the width of the sidebar on a page template or layout.

Possible Solution:

  1. Make sidebar control value accessor so it can update the form controller.
  2. Sidebar object should be like
{
    sidebar: {
       location: 'left',
       width: 'small || medium || large'
   }
}
  1. The widthPercent we'll handle it in the BE
  2. We pretty much need to do the same thing we did here

Mock

sidebar 1

Acceptance Criteria

  1. Match the design
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
  5. We should save in the server a string of: small, medium or large
  6. Dropdown menu should set the width of the sidebar and the gray block should be
    • small: 200px
    • medium: 250px
    • large: 300px
  7. Save the setting to the backend.
  8. Update the template.vtl
@fmontes fmontes added this to the Fox Next milestone Jan 3, 2018
@luisrojascr luisrojascr self-assigned this Jan 19, 2018
luisrojascr pushed a commit that referenced this issue Jan 23, 2018
luisrojascr pushed a commit to dotCMS/core-web that referenced this issue Jan 23, 2018
@fmontes
Copy link
Member Author

fmontes commented Jan 24, 2018

template.vtl needs more work, when you remove the sidebar the object sidebar still exit so it still show the <div> for the sidebar, I think we need to compare with $sidebar.location

@fmontes
Copy link
Member Author

fmontes commented Jan 24, 2018

fmontes pushed a commit to dotCMS/core-web that referenced this issue Jan 24, 2018
@fmontes fmontes closed this as completed Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants